Repository navigation
Skip external trait scans for absent associated item names - #380
Draft
charliermarsh wants to merge 1 commit into
Draft
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
changed the base branch from
charlie/pin-cargo-release-28
to
archive/ohm-1.99.0-34/charlie/pin-cargo-release-28
November 17, 2026 07:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the seven-file uv edit, this change reduced instruction counts for the complete
uvlibrary check by 0.41% and 0.45% in two opposite-order comparisons against the Ohm −28 source. Across all 14 rustc processes in the workspace check, the reductions were 0.24% and 0.23%. uv #19612Six fresh confirmation pairs compared optimized stage-1 builds of this branch (
86dcd155) and its Ohm −28 base (0b290350) on the same edit. The completeuvlibrary used fewer instructions in all six pairs (two-sided sign test, p = 0.03125).uvlibraryuv-resolverWhen resolving a method or associated item, we scan the bindings of each candidate external trait for the requested name. We now record which symbol numbers occur in each trait in a 256-bit set in the resolver's dropless arena. If a bit is clear, the trait has no matching name. If it's set, we still scan the bindings and check the namespace.
On our compiler stack, the same change reduced instructions in
uvby 0.46% across eight fresh pairs (range 0.40%–0.51%). All six pre-specified confirmation pairs favored the patch (two-sided sign test, p = 0.031).uv-resolverused 0.28% fewer instructions and the full workspace check used 0.28% fewer. The number of trait lookups inuvstayed at 24,102 in both pilot pairs. Instructions intraits_in_scopefell from 69.3M to 40.7M.We compared optimized stage-1 builds using the same Cargo. Each compiler warmed its own incremental state at
f69c1b274, applied the seven-file edit ate5a0e18f8, then rancargo +ohm check --locked --offline -j8at the workspace root. We used Valgrind Callgrind to count executed instructions in each rustc process during the first check after the edit.